feat(vest): Add AbortSignal as a parameter to test #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ealush
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
650dfc9 Remove coverage workflow (Evyatar) cbd27ad vx: recover from missing stable branch (Evyatar) 828085b minor(vest): Suite.subscribe for listening to state changes (Evyatar) 37a4031 minor(vest-utils): add suport for wildcard bus event (Evyatar) 89a843f patch(vest): Suite dump runs on available root (Evyatar) 26b4a09 patch(n4s): downgrade validator (Evyatar) 2d28ea7 feat(vest): Add AbortSignal as a parameter to test (#1079) (Evyatar) 4260f59 types: fix vest.IsolateTest types in tests (Evyatar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering passing an AbortSignal to each of the tests in the suite, allowing consumers to abort their async operations once Vest cancels these tests.
Using AbortSignal
Each test function is passed an object with a
signalproperty. This signal is an AbortSignal which can be used to terminate your async operations once a test is canceled.The AbortSignal has a boolean
abortedproperty, by which you can determine whether the test was canceled or not.A test gets canceled when running the same test again before its previous run has completed.
You can use the AbortSignal to stop the execution of your async test, or pass it to your fetch request.
More on AbortSignal.